chore: Make tree-sitter optional#2450
Merged
Merged
Conversation
stayhydated
force-pushed
the
tree-sitter-optional
branch
from
c96bf7b to
26b319b
Compare
stayhydated
changed the title
stayhydated
force-pushed
the
tree-sitter-optional
branch
from
3cae3f6 to
d3966eb
Compare
Collapse the compound predicates (all(not(wasm), feature "tree-sitter") and any(wasm, not(feature "tree-sitter"))) down to `feature = "tree-sitter"` and its negation. The wasm dimension was redundant: story-web builds with default-features = false, so tree-sitter is always off on wasm and the stub path already covers it. Using `X` vs `not(X)` also makes the two paths mutually exclusive by construction, so they can no longer drift apart. Add a CI step to guard the disabled path: `cargo check -p gpui-component --no-default-features`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make tree-sitter optional
How to Test
Checklist
cargo runfor story tests related to the changes.